Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid links in the notebooks (transferred from source) #88

Open
aadsouza opened this issue May 7, 2021 · 8 comments
Open

Invalid links in the notebooks (transferred from source) #88

aadsouza opened this issue May 7, 2021 · 8 comments
Labels

Comments

@aadsouza
Copy link
Contributor

aadsouza commented May 7, 2021

@WenxinM:
"This issue is transferred from the myst repo

There are two invalid links in the current notebooks, possibly due to the nested structure of the exercise.

**Exercise 3**

Let's revisit the unemployment example from the {doc}`linear algebra lecture <applied_linalg>`.

We'll repeat necessary details here.
**Exercise 5**

Let's revisit a bond pricing example we saw in {doc}`Control flow <../python_fundamentals/control_flow>`.

@arnavs"

@aadsouza:
"one more: https://datascience.quantecon.org/pandas/merge.html links to https://www.transtats.bts.gov/ErrPage.asp
edit: https://quantecon.github.io/lecture-datascience.myst/pandas/groupby.html also links to BTS

https://www.census.gov/geo/maps-data/data/cbf/cbf_state.html invalid as well

https://scikit-learn.org/stable/auto_examples/svm/plot_iris.html in classification lecture"

@wupeifan
Copy link
Contributor

wupeifan commented May 7, 2021

Are these all still remaining issues or actually most of them are solved? I might know how to fix some of them if you guys don't have a solution yet.

@aadsouza
Copy link
Contributor Author

aadsouza commented May 7, 2021

seeing as they were in the source repo and we most likely forgot about them until now, I believe that these are open issues.

@wupeifan
Copy link
Contributor

wupeifan commented May 9, 2021

@aadsouza The first two links are just cross-lecture links and I'll just leave them for you guys to fix. The links you mentioned are all fixed in #91

@aadsouza
Copy link
Contributor Author

aadsouza commented May 9, 2021

adding this to the list of external links that need to be fixed QuantEcon/lecture-datascience.notebooks#1 (comment)

@aadsouza
Copy link
Contributor Author

also, internal links appear to be invalid throughout the notebook, not just those exercises.

@mmcky
Copy link
Contributor

mmcky commented May 10, 2021

@aadsouza can you open an issue on https://github.com/QuantEcon/sphinx-tojupyter and link to this one. This relates to the download notebooks?

@aadsouza
Copy link
Contributor Author

The problem with the internal links generated in the nbs is that they forget to include the subdirectories in the path. For example if it needs to link to the reg lecture, it goes ds.qe.org/reg, instead of ds.qe.org/apps/reg. My initial idea was to change the path in the lecture itself from reg to ../apps/reg and various permutations which did not work, but then noticed that in the conf yaml we have tojupyter_urlpath: "https://datascience.quantecon.org/" but it is likely we need something like tojupyter_urlpath: "https://datascience.quantecon.org/subrepo" where subrepo \in \{apps, sci, fundamentals, intro, pd, etc...\} .

@WenxinM
Copy link
Contributor

WenxinM commented May 11, 2021

Note to self: @WenxinM check the internal link in Colletions, python fundementals, search for Note that in order to sort.
More in functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants