Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer for the notebook repo to source control (for codespaces and vscode remote options) #183

Open
3 tasks
jlperla opened this issue Aug 13, 2021 · 4 comments

Comments

@jlperla
Copy link
Member

jlperla commented Aug 13, 2021

Current there is a test branch directly on the notebook repo: https://github.com/QuantEcon/lecture-datascience.notebooks/tree/devcontainer-test/.devcontainer

@mmcky and @Alim-faraji Is that possible? We don't want to maintain those files in the notebook repo separately.

@jlperla
Copy link
Member Author

jlperla commented Aug 13, 2021

@jbrightuniverse FYI. You can test when this is complete and these are deployed to the repo.

@mmcky
Copy link
Contributor

mmcky commented Aug 13, 2021

@jlperla absolutely. The _notebook_repo is the best spot for it as github actions builds the notebooks repo and then pushes it during the publish.yml workflow.

@jlperla
Copy link
Member Author

jlperla commented Aug 13, 2021

Great. Is this something that @jbrightuniverse and @Alim-faraji can do on their own? Does he just need to put the files in there and they automatically copy over?

@mmcky
Copy link
Contributor

mmcky commented Aug 13, 2021

basically -- and harmonise with lecture-python.myst action by adding the work to sync the generated notebooks to the repo in publish.yml updating for julia

      - name: Prepare lecture-python.notebooks sync
        shell: bash -l {0}
        run: |
          mkdir -p _build/lecture-python.notebooks
          cp -a _notebook_repo/. _build/lecture-python.notebooks
          cp _build/jupyter/*.ipynb _build/lecture-python.notebooks
          ls -a _build/lecture-python.notebooks
      - name: Commit latest notebooks to lecture-python.notebooks
        uses: cpina/[email protected]
        env:
          API_TOKEN_GITHUB: ${{ secrets.QUANTECON_SERVICES_PAT }}
        with:
          source-directory: '_build/lecture-python.notebooks/'
          destination-repository-username: 'QuantEcon'
          destination-repository-name: 'lecture-python.notebooks'
          commit-message: 'auto publishing updates to notebooks'
          destination-github-username: 'quantecon-services'
          user-email: [email protected]

I will need to add the QUANTECON_SERVICES_PAT to push to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants