Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate np.dot to use python @ #589

Open
mmcky opened this issue Nov 11, 2021 · 3 comments · May be fixed by #687
Open

Migrate np.dot to use python @ #589

mmcky opened this issue Nov 11, 2021 · 3 comments · May be fixed by #687

Comments

@mmcky
Copy link
Contributor

mmcky commented Nov 11, 2021

It would be nice to migrate np.dot to use the inbuilt python @ operator for matrix multiplication.

Some thought is required as np.dot doesn't behave in the exact same way as @

https://stackoverflow.com/questions/34142485/difference-between-numpy-dot-and-python-3-5-matrix-multiplication

@nshea3
Copy link
Contributor

nshea3 commented Nov 17, 2021

Hi! I've started to work on this change (https://github.com/nshea3/QuantEcon.py/tree/migrate-matmul-symbol)

Changes to lqnash and lqcontrol are both in progress. np.dot is used in many places in the repo so I think it will be a few weeks before I send along a PR.

Thanks for the stackoverflow post, useful info there!

Nick

@mmcky
Copy link
Contributor Author

mmcky commented Nov 18, 2021

thanks @nshea3 -- appreciate it.

@HumphreyYang
Copy link
Collaborator

Hi everyone, I will take this issue. Let me know if there is anyone else working on this :)

@HumphreyYang HumphreyYang linked a pull request Jan 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants