-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependence on matplotlib #262
Comments
@jstac I agree with the sentiment, but worry that writing functions and methods that depend on an axes instance leaves us with an implicit dependency on How much code is actually using plotting functionality? There are so many good plotting libraries out there and given that preferences over optimal plotting libraries are quite idiosyncratic (i.e., there is no dominant visualization library) perhaps we should consider removing all plotting code. Code we have now could be moved to examples that demonstrate usage of the core library. This would leave us with less code to maintain in the long run and leave the choice of data viz tooling entirely to the end user. |
@davidrpugh That's probably a good idea. I just ran a search and only Thanks ;-) |
Was just thinking about this -- Long story which I'll generate another thread for. It doesn't look like we ever removed this dependency. Are people still in favor of removing this dep? (I am) |
@cc7768 Yes, definitely, I just haven't had time... |
Agreed! |
Seems we can close this @mmcky? |
indeed. Thanks @natashawatkins |
At least some modules pull in
matplotlib
, such as this one:https://github.com/QuantEcon/QuantEcon.py/blob/master/quantecon/arma.py
Let's get rid of this dependency if possible. One way to do this when we have functions that generate plots is to have them take an
axes
instance as an argument and write to it.(This could be added to the contributions style guide.)
The text was updated successfully, but these errors were encountered: