-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO: Add states/nodes to MarkovChain/DiGraph #101
Comments
A reminder: Once states are added to MCs on the Python side we should do the same on the Julia side. |
One quick thought: it may not be efficient to create an set of states 0:n-1 when the markov change is initialized. Knowing that we have the canonical states may allow to speed up some algorithm (like simulation). In that case, it would be better to either keep None for the list of states or to register somewhere that we have the canonical nodes with a dedicated field (e.g. canonical_states in (true, false) ) |
@albop Good point about efficiency. Aside: It's frustrating that we have these algorithm-level discussion in the py or jl issue trackers and end up duplicating comments --- in this case with QuantEcon/QuantEcon.jl#22. Regarding the right format for the states, in the majority of cases people will want to work with an array of scalars. Do we need anything more sophisticated? |
Todo remainder, following the discussion in the Julia side:
MarkovChain
DiGraph
Cf.
The text was updated successfully, but these errors were encountered: