-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited warnings #144
Merged
Merged
edited warnings #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Current coverage is 93.12% (diff: 62.50%)@@ master #144 diff @@
==========================================
Files 19 19
Lines 1146 1149 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1070 1070
- Misses 76 79 +3
Partials 0 0
|
oyamad
reviewed
Sep 29, 2016
elseif iterate == max_iter | ||
warn("max_iter attained in compute_fixed_point") | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this?
if verbose >= 1
if iterate == max_iter
warn("max_iter attained in compute_fixed_point")
elseif verbose == 2
println("Converged in $iterate steps")
end
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's much better ;-)
I'll make the change.
oyamad
added a commit
to QuantEcon/QuantEcon.py
that referenced
this pull request
Nov 9, 2016
oyamad
added a commit
to QuantEcon/QuantEcon.py
that referenced
this pull request
Nov 14, 2016
oyamad
added a commit
to QuantEcon/QuantEcon.py
that referenced
this pull request
Nov 14, 2016
oyamad
added a commit
to QuantEcon/QuantEcon.py
that referenced
this pull request
Nov 14, 2016
This was referenced Nov 14, 2016
oyamad
added a commit
to QuantEcon/QuantEcon.py
that referenced
this pull request
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: