Add SA pairs to ddp #100
Merged
Add SA pairs to ddp #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Added state-action pair types and some of the methods" This reverts commit b4e743a. Added state-action pair types and methods
Cleaning #2 Remove dummy file refactor ddp types improving s-a pair formulation improving s-a pair formulation run some tests over both dense and sparse allow Q to be sparse in SA constructor Minor touchups Updates to State-Action Pair tests. TODO @sglyon needs attention Added note about linear vs cartesian indexing Updates to documentation for Outer Constructors, and other minor tweaks to improve formating fix @test_throws errors for dense ddp move to cartesian indexing for dense ddp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off the work of @albep and adds state-action pair formulation to DDP.jl
Notable changes are:
I consider this an intermediate step. The next phase should be to transpose all the routines so they naturally fall in line with Julia's column major array layout. Right now the implementation of some routines is suboptimal, mainly because I didn't want to spend time making them uber efficient if they will be shortly replaced.
Comments welcome.