Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Data-Provider and Data-Feed #1614

Closed
3 tasks done
Romazes opened this issue Feb 8, 2024 · 0 comments · Fixed by #1623
Closed
3 tasks done

Rename Data-Provider and Data-Feed #1614

Romazes opened this issue Feb 8, 2024 · 0 comments · Fixed by #1623

Comments

@Romazes
Copy link
Contributor

Romazes commented Feb 8, 2024

Expected Behavior

See PR - click

These params were renamed:

  • --data-provider -> --data-provider-historical (to retrieve data from the given historical provider)
  • --data-feed -> --data-provider-live (the live data provider to use)

Should use new terminology in lean-cli.
These changes were implemented in:

  • lean backtest
  • lean optimize
  • lean research
  • lean live deploy

Actual Behavior

Datasets are using wrong command in examples.

Mention: --data-provider

IEX Cloud

Link

https://www.quantconnect.com/docs/v2/lean-cli/datasets/iex-cloud

Image

image

IQFeed

Link

https://www.quantconnect.com/docs/v2/lean-cli/datasets/iqfeed

Image

image

Polygon

Link

https://www.quantconnect.com/docs/v2/lean-cli/datasets/polygon

Image

image

Mention: data-feed

IQFeed

Link

https://www.quantconnect.com/docs/v2/lean-cli/live-trading/data-feeds/iqfeed

Image

image

Polygon

Link

https://www.quantconnect.com/docs/v2/lean-cli/live-trading/data-feeds/polygon

Image

image

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant