Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml and readme #67

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Update pyproject.toml and readme #67

merged 3 commits into from
Jul 19, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Jul 17, 2023

This PR,


pyproject.toml

This change is necessary for fixing build and installation errors using the pyproject.toml

This is one of the errors that was appearing,

The following seems to be defined outside of `pyproject.toml`:
`authors = 'quansight-labs'`
According to the spec (see the link below), however, setuptools CANNOT
consider this value unless `authors` is listed as `dynamic`.
https://packaging.python.org/en/latest/specifications/declaring-project-metadata/
For the time being, `setuptools` will still consider the given value (as a
**transitional** measure), but please note that future releases of setuptools will
follow strictly the standard.
To prevent this warning, you can list `authors` under `dynamic` or alternatively
remove the `[project]` table from your file and rely entirely on other means of
configuration.
By 2023-Oct-30, you need to update your project and remove deprecated calls
or your builds will no longer be supported.

readme

One necessary step of the local installation process was removed from the instructions

@steff456 steff456 added the type: bug 🐛 Something isn't working label Jul 17, 2023
@steff456 steff456 requested a review from trallard July 17, 2023 20:23
@steff456 steff456 self-assigned this Jul 17, 2023
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/steff456-patch-1

@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/steff456-patch-1

1 similar comment
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/steff456-patch-1

@steff456 steff456 changed the title Update pyproject.toml Update pyproject.toml and readme Jul 17, 2023
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve and merge, but will follow up with another PR to make some improvements

@trallard trallard merged commit ff63d3f into main Jul 19, 2023
@trallard trallard deleted the steff456-patch-1 branch July 19, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants