Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements needed on themes #59

Closed
9 of 13 tasks
Tracked by #56
trallard opened this issue Jun 29, 2023 · 0 comments · Fixed by #62
Closed
9 of 13 tasks
Tracked by #56

Miscellaneous improvements needed on themes #59

trallard opened this issue Jun 29, 2023 · 0 comments · Fixed by #62
Labels
block-release type: bug 🐛 Something isn't working

Comments

@trallard
Copy link
Member

trallard commented Jun 29, 2023

GitHub light

  • The active tab colour is not noticeable (need to swap to a different colour)
    plugin_json_-_JupyterLab

Compared to GitHub dark
plugin_json_-_JupyterLab

  • Hover background (menu) does not have enough contrast against the background colour
    RELEASE_md__2__-_JupyterLab

  • Colours in the kernel/tab manager sidebar have gone missing - all is grey now, which makes it look like it is all text and lacks some of the "warning" type contexts
    RELEASE_md__2__-_JupyterLab

Compared to JupyterLab light
RELEASE_md__2__-_JupyterLab

  • There is no active indicator on the search bar

RELEASE_md__2__-_JupyterLab

Compared to JupyterLab light

RELEASE_md__2__-_JupyterLab

  • Toggle background is not noticeable
    RELEASE_md__2__-_JupyterLab

GitHub dark

  • Selected file in File browser has no background (or is the same as the overall sidebar background)

JupyterLab

Compared to JupyterLab light
JupyterLab

  • Some icons are rendered in black, which does not have enough contrast against the background (in general the colours of the icons are all very similar, same on the light theme)

binder_-_JupyterLab

Compared to JupyterLab dark
binder_-_JupyterLab

  • Hover background (menu) does not have enough contrast against the background colour
    RELEASE_md__2__-_JupyterLab

  • Colours in the kernel/tab manager sidebar have gone missing - all is grey now, which makes it look like it is all text and lacks some of the "warning" type contexts
    RELEASE_md__2__-_JupyterLab

  • There is no active indicator on the search bar
    RELEASE_md__2__-_JupyterLab

Pitaya Smoothie

  • Some icons are rendered in black, which does not have enough contrast against the background
    binder_-_JupyterLab

  • There is no active indicator on the search bar
    RELEASE_md__2__-_JupyterLab

  • When changing the theme to Pitaya Smoothie, the bottom bar disappears
    RELEASE_md__2__-_JupyterLab

Compared to GH dark
RELEASE_md__2__-_JupyterLab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-release type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging a pull request may close this issue.

1 participant