Focus visible test #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
8 tasks
gabalafou
force-pushed
the
focus-visible
branch
from
4ec10f5
to
645220a
Compare
gabalafou
force-pushed
the
focus-visible
branch
from
135353f
to
33188a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to check that every tab-focusable element on the initial JupyterLab page load has a visible focus indicator. A full description of the test is in the markdown file added by this PR.
The test currently fails because the skip link is broken.
There is another failure related to the top menu bar that jupyterlab/lumino#607 fixes. You can see that the Lumino PR fixes the failure by examining the results of a workflow that I manually dispatched. I configured that workflow to run the test in this PR against a build of JupyterLab that pulled in the Lumino fix. In the workflow run results, you can see that the focus visible comparison only fails on the skip link and not on any other DOM node (specifically, not on any DOM node in the menu bar).