FEAT - Split Lab build into an action of its own #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
type: enhancement 💅🏼
trallard
changed the title
|
That summary formatting is wonky, so I might need to figure out a way to deal with it... not urgent tho |
gabalafou
approved these changes
Jan 20, 2023
|
Approved for now. If anything's not working we can fix it in subsequent pull requests. |
|
I am going to merge this and if needed work on smaller self-contained improvements |
trallard
force-pushed
the
trallard/install-action
branch
from
1913661 to
7bd9ea3
Compare
|
Note I had to upgrade to node >= 18 on our deps (ljlab) since now whatever is in |
gabalafou
requested changes
Mar 17, 2023
Co-authored-by: gabalafou <[email protected]>
Revert message
|
@gabalafou fixed the issues - except for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
TODO as part of this PR
mainSHAfor Lumino build/link in case this is needed🎉 I now modified the PR so that we can take the repo and
refof almost any package to build and test with JupyterLabThis run combines
jupyterlab/jupyterlabwith the branch from mark's lumino's PR that @gabalafou is currently reviewing (scmmmh/lumino) https://github.com/Quansight-Labs/jupyter-a11y-testing/actions/runs/3961294989