Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt refactor of Doit-based code in jupyter_accessibility #13

Closed
gabalafou opened this issue Aug 18, 2022 · 2 comments
Closed

Attempt refactor of Doit-based code in jupyter_accessibility #13

gabalafou opened this issue Aug 18, 2022 · 2 comments
Assignees
@gabalafou

Comments

@gabalafou
Copy link
Contributor

The Python code that Tony wrote under jupyter_accessibility directory is on object-oriented wrapper around Doit.py.

My goal is to try to refactor that code to look more like conventional Doit scripts, for example, the dodo.py file that Nick wrote in jupyter/accessibility.
@gabalafou gabalafou self-assigned this Aug 18, 2022
@trallard trallard moved this to 🆕 New in jupyter-a11y-tools 🛠 Aug 18, 2022
@gabalafou gabalafou mentioned this issue Aug 18, 2022
Closed
@gabalafou
Copy link
Contributor Author

I'm behind on this task. I spent Friday going through the entire doit.py docs. Now I'm tackling the actual code in the repo.

This was referenced Aug 24, 2022
Closed
Closed
@gabalafou gabalafou mentioned this issue Sep 1, 2022
Closed
@trallard
Copy link
Member

trallard commented Sep 2, 2022

From the meeting on 01 Sept - we decided to abandon this route at least for now

@trallard trallard closed this as completed Sep 2, 2022
Repository owner moved this from 🆕 New to ✅ Done in jupyter-a11y-tools 🛠 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabalafou gabalafou

Labels
None yet
Projects
jupyter-a11y-tools 🛠
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor test code into more conventional imperative Doit style Quansight-Labs/jupyter-a11y-testing
2 participants
@gabalafou @trallard