Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing export definition #38

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Adding missing export definition #38

merged 1 commit into from
Aug 1, 2018

Conversation

karan-kang
Copy link
Contributor

No description provided.

@Qix-
Copy link
Owner

Qix- commented Aug 1, 2018

This doesn't do anything - it's a no-op. cs.get is overwritten directly below it.

@karan-kang
Copy link
Contributor Author

karan-kang commented Aug 1, 2018 via email

@Qix-
Copy link
Owner

Qix- commented Aug 1, 2018

Yeah that's the problem with webpack, its static analysis is... bad.

Fine, but I'm doing this begrudgingly. Tooling should be better at detecting this.

@Qix- Qix- merged commit 38f6424 into Qix-:master Aug 1, 2018
@Qix-
Copy link
Owner

Qix- commented Aug 1, 2018

Released as 1.5.3.

Thanks for the PR.

@karan-kang
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants