You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the use of DictMap was introduced in #386 there has been a regression caused in places that used to use a HashMap for the output type. This is probably because of the additional overhead in generating an indexmap vs a hashmap. For example, looking at #489 I benchmarked dijkstra from https://github.com/mtreinish/retworkx-comparison-benchmarks with 0.10.2, main, and #489 (which we can ignore for this issue):
As you can see there for the single source case there is a noticeable regression for main vs 0.10.2. Before the 0.11.0 release I think we should revisit #386 and determine if there is a performance regression where DictMap is used and if so whether we think a deterministic iteration order is worth that extra overhead.
The text was updated successfully, but these errors were encountered:
Now that #493 merged I think we can close this. There is probably a small regression in other places we switched to use dictmap, but we can revisit this in a follow-up where we encounter it.
Information
What is the current behavior?
Since the use of
DictMap
was introduced in #386 there has been a regression caused in places that used to use aHashMap
for the output type. This is probably because of the additional overhead in generating an indexmap vs a hashmap. For example, looking at #489 I benchmarked dijkstra from https://github.com/mtreinish/retworkx-comparison-benchmarks with 0.10.2, main, and #489 (which we can ignore for this issue):As you can see there for the single source case there is a noticeable regression for
main
vs 0.10.2. Before the 0.11.0 release I think we should revisit #386 and determine if there is a performance regression whereDictMap
is used and if so whether we think a deterministic iteration order is worth that extra overhead.The text was updated successfully, but these errors were encountered: