-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_subgraph_isomorphic
function
#317
Conversation
Pull Request Test Coverage Report for Build 886373020
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, is_subgraph_isomorphic
reuses almost all is_isomorphic
code which in my opinion is an indicator of good design!
Just a minor debate: should we use a macro and pass $op
, or should we go with a more standard approach and use an Ordering argument?
I am biased towards passing an argument, it feels closer to how we write our Python code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, just some issues with the docstring for the universal function and the default for id_order
python is different from the rust functions we probably want it to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The diff is larger using Ordering
, but ultimately I believe it will be easier to maintain.
Co-authored-by: Matthew Treinish <[email protected]>
Adds a function to determine if two graphs are induced subgraph isomorphic.
This new feature is simple to implement since it's the same code with
is_isomorphic
function except in feasibility rules we check>=
relation instead of==
.