From 660ca2d7fd1a8c4a1f514b6c2380359f86f62986 Mon Sep 17 00:00:00 2001 From: Jake Lishman Date: Thu, 4 Jan 2024 12:28:02 +0000 Subject: [PATCH] Make `typing_extensions` required on all Python versions The extent of our use of `typing_extensions` has fluctuated over time, but we've often had a dependency on it. This is typically not an onerous dependency, being pure Python, and is not uncommon for other packages. We've often had an upper limit on the Python version for it, just for the principle of least requirements, but this has led to a subtle bug recently where we began using a Python 3.12 feature from it (`Unpack`) with the requirement left at `python_version<'3.11'` from before. This was caught by our nightly full test suite, but for unrelated reasons, that's not commenting correctly on issues at the moment. This error is quite likely to repeat; we only use the backport package for Python versions that _aren't_ the newest, but our PR CI tests only oldest and newest. This commit simply lifts the upper limit on the package; the impact should be minimal since most environments will already be installing it. --- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index 6402e9a6549f..da632a885ce7 100644 --- a/requirements.txt +++ b/requirements.txt @@ -6,5 +6,5 @@ sympy>=1.3 dill>=0.3 python-dateutil>=2.8.0 stevedore>=3.0.0 -typing-extensions; python_version<'3.11' +typing-extensions symengine>=0.9,!=0.10.0