Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support control flow in ConsolidateBlocks #9426

Closed
Tracked by #9417 ...
jakelishman opened this issue Jan 23, 2023 · 0 comments · Fixed by #10355
Closed
Tracked by #9417 ...

Support control flow in ConsolidateBlocks #9426

jakelishman opened this issue Jan 23, 2023 · 0 comments · Fixed by #10355
Labels
mod: transpiler Issues and PRs related to Transpiler type: feature request New feature or request
Milestone

Comments

@jakelishman
Copy link
Member

jakelishman commented Jan 23, 2023

What should we add?

Part of #9417. Depends on #9425. Will interact with other efforts in #8779.

The ConsolidateBlocks pass is run by default at optimisation level 3, and (albeit very uncommon in practice) is used by the synthesis routing method at all levels. This currently cannot support control-flow, primarily because the data format it reads has no way of representing that knowledge. Once a solution to #9425 is in place, this pass should be upgraded to use that information, and enter control-flow blocks where appropriate.

The implementation of the control-flow parts of this will likely end up looking quite similar to that of CommutativeCancellation: see #9423.

@jakelishman jakelishman added type: feature request New feature or request mod: transpiler Issues and PRs related to Transpiler labels Jan 23, 2023
@jakelishman jakelishman added this to the 0.24.0 milestone Jan 23, 2023
@jakelishman jakelishman changed the title Support control-flow in ConsolidateBlocks Support control flow in ConsolidateBlocks Jan 23, 2023
@jakelishman jakelishman modified the milestones: 0.24.0, 0.25.0 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: transpiler Issues and PRs related to Transpiler type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant