Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid product-code depending on tests #669

Closed
delapuente opened this issue Jul 20, 2018 · 3 comments
Closed

Avoid product-code depending on tests #669

delapuente opened this issue Jul 20, 2018 · 3 comments

Comments

@delapuente
Copy link
Contributor

What is the expected enhancement?

Find a better way of resolving this:
https://github.com/Qiskit/qiskit-terra/pull/547/files#diff-c3448a8c2134a492e0f08f2131d5552dR248

@diego-plan9
Copy link
Member

Can you edit the issue and elaborate a bit? I believe you actually want to refer mostly to the tearDown() method, which was introduced due to the implications of import qiskit bringing the wrappers' _DEFAULT_PROVIDER as it is a module variable, and ends up being initialized only once per test suite.

@delapuente
Copy link
Contributor Author

You're right but I don't know for sure. That's part of the issue, I think. When I gain more insight, I will elaborate on the description.

@delapuente
Copy link
Contributor Author

I did not realize this is not product-code but part of the testing infrastructure. My bad, sorry.

@delapuente delapuente changed the title Avoid production code depending on tests Avoid product-code depending on tests Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants