Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dag.extend_back() not general and dag.compose_back() hard to use #3769

Closed
ajavadia opened this issue Jan 30, 2020 · 1 comment · Fixed by #3772
Closed

dag.extend_back() not general and dag.compose_back() hard to use #3769

ajavadia opened this issue Jan 30, 2020 · 1 comment · Fixed by #3772
Assignees
@ajavadia
Labels
status: pending PR It has one or more PRs pending to solve this issue type: enhancement It's working, but needs polishing

Comments

@ajavadia
Copy link
Member

DAGCircuit.extend_back() was created as a wrapper around DAGCircuit.compose_back(), making the wiring requirements more relaxed (allows partial wiring). But it is not general and only works on physically-embedded circuits (see #3762 (review)). I think we should just remove this method and make compose_back() also work with partial wirings.
@ajavadia ajavadia added the bug Something isn't working label Jan 30, 2020
@ajavadia ajavadia self-assigned this Jan 30, 2020
@ajavadia
Copy link
Member Author

I'll see if I can fix this.

@eddieschoute eddieschoute mentioned this issue Jan 30, 2020
Merged
@ajavadia ajavadia mentioned this issue Jan 31, 2020
Merged
@1ucian0 1ucian0 added status: pending PR It has one or more PRs pending to solve this issue type: enhancement It's working, but needs polishing and removed bug Something isn't working labels Feb 14, 2020
@mergify mergify bot closed this as completed in #3772 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajavadia ajavadia

Labels
status: pending PR It has one or more PRs pending to solve this issue type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

generalize dag.compose_back(), deprecate dag.extend_back() ajavadia/qiskit
2 participants
@1ucian0 @ajavadia