Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the LUCJ ansatz be moved from ffsim to qiskit? #13573

Open
kevinsung opened this issue Dec 16, 2024 · 0 comments
Open

Should the LUCJ ansatz be moved from ffsim to qiskit? #13573

kevinsung opened this issue Dec 16, 2024 · 0 comments
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library

Comments

@kevinsung
Copy link
Contributor

ffsim includes a qiskit module that you can use to construct LUCJ circuits. This function seems to be quite popular, even though it is somewhat tangential to ffsim's core functionality as a state vector simulation tool. The SQD tutorial on the learning platform depends on ffsim, only to use this function. Therefore, it might make sense to move the LUCJ circuit functionality into Qiskit. For an example of constructing an LUCJ circuit and sampling bitstrings from it using ffsim's implementation of the Sampler primitive, see this guide.

Here are some reasons we might not want to move the LUCJ code into Qiskit:

  • It has a nontrivial dependency on the ffsim.linalg module, so it would not be a clean split, and there would end up being some duplication between Qiskit and ffsim.
  • It has a soft dependency on a chemistry package such as PySCF because the ansatz is typically initialized using the output of a chemistry calculation (t2 amplitudes from, i.e., CCSD).
  • It is application-specific. LUCJ is designed for quantum chemistry simulations.

It probably makes sense to resolve #13571 first.

@kevinsung kevinsung added the mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

No branches or pull requests

1 participant