Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop storing default unit="dt" in rust space extra attributes by default #12900

Closed
mtreinish opened this issue Aug 4, 2024 · 0 comments · Fixed by #13078
Closed

Stop storing default unit="dt" in rust space extra attributes by default #12900

mtreinish opened this issue Aug 4, 2024 · 0 comments · Fixed by #13078
Labels
performance Rust This PR or issue is related to Rust code in the repository

Comments

@mtreinish
Copy link
Member

What should we add?

Right now when adding gates to a circuit from Python the default value of the unit field ends up meaning we populate the rust space extra attributes field in the circuit instruction and filling it with a unit of "dt". This is just wasted memory that we shouldn't need to waste since everything has an implicit default of "dt", the extra attributes in the rust data model was designed only to store custom values for the mutable state for instructions. We should update the logic when adding gates from Python to Rust space to avoid setting extra attributes if unit="dt".

@mtreinish mtreinish added type: feature request New feature or request performance Rust This PR or issue is related to Rust code in the repository and removed type: feature request New feature or request labels Aug 4, 2024
@mtreinish mtreinish linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant