Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support manual variables in QuantumCircuit.compose #10932

Closed
Tracked by #10922
jakelishman opened this issue Oct 2, 2023 · 0 comments · Fixed by #12215
Closed
Tracked by #10922

Support manual variables in QuantumCircuit.compose #10932

jakelishman opened this issue Oct 2, 2023 · 0 comments · Fixed by #12215
Assignees
@jakelishman
Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Milestone
1.1.0

Comments

@jakelishman
Copy link
Member

jakelishman commented Oct 2, 2023 •
edited
Loading

For simplicity in the initial implementation, we can likely reject any attempts to compose two circuits that use the same variable instances or have naming clashes; this is functionality we can design and add later if it transpires to be necessary.

See discussion in https://github.com/Qiskit/RFCs/pull/50/files#r1328805042 and https://github.com/Qiskit/RFCs/pull/50/files#r1329111336 for more.
@jakelishman jakelishman mentioned this issue Oct 2, 2023
Closed
@jakelishman jakelishman added this to the 0.45.0 milestone Oct 2, 2023
@jakelishman jakelishman added the mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library label Oct 2, 2023
@jakelishman jakelishman mentioned this issue Oct 2, 2023
Closed
@jakelishman jakelishman modified the milestones: 0.45.0, 1.0.0 Oct 5, 2023
@mtreinish mtreinish modified the milestones: 1.0.0, 1.1.0 Jan 23, 2024
@jakelishman jakelishman self-assigned this Apr 19, 2024
@jakelishman jakelishman mentioned this issue Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelishman jakelishman

Labels
mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Support Var in circuit-substitution methods jakelishman/qiskit-terra
2 participants
@mtreinish @jakelishman