Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit benchmark suite for QuantumCircuit.assign_parameters #10822

Open
jakelishman opened this issue Sep 12, 2023 · 0 comments
Open

Revisit benchmark suite for QuantumCircuit.assign_parameters #10822

jakelishman opened this issue Sep 12, 2023 · 0 comments
Labels
type: qa Issues and PRs that relate to testing and code quality

Comments

@jakelishman
Copy link
Member

jakelishman commented Sep 12, 2023

We need to take a little care when modifying benchmarks, because any change invalidates the whole trace. If we're doing this (and we probably should), we probably want to take a todo issue to write more complete benchmarks of assign_parameters that test more of the input formats / combinations.

Originally posted by @jakelishman in #10792 (comment)

At the moment our benchmarking for QuantumCircuit.assign_parameters is not really indicative of the different typical access patterns. We should be testing the time taken to assign single parameters out of big lists in a loop (using the dictionary input), to assign all the parameters using the dictionary input and to assign all the parameters using an array input. We care about both inplace and new-circuit returns.

For different cases, we care about big "flat" circuits (think many rzs), but also about very deep composite circuits (think algorithm-like things with recursive structures within single compound instructions).

@jakelishman jakelishman added the type: qa Issues and PRs that relate to testing and code quality label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

No branches or pull requests

1 participant