Replace DAGNode class with OpNode, InNode, and OutNode classes #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enavarro51
requested review from
nkanazawa1989,
nonhermitian and
a team
as code owners
kdk
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Thanks @enavarro51 , this looks good so far. One question on the DAGNode parent class.
kdk
reviewed
Jun 23, 2021
There was a problem hiding this comment.
Thanks @enavarro51 , this looks good so far. Few comments below.
releasenotes/notes/dag_node_to_op_in_out_node-af2cf9c3e7686285.yaml
Outdated
Show resolved
Hide resolved
…deprecated in DAGNode
kdk
reviewed
Jul 7, 2021
There was a problem hiding this comment.
Looks great, thanks for the updates @enavarro51 . One more question about deprecation warnings, then I think this on hold for #6694 .
kdk
reviewed
Aug 2, 2021
There was a problem hiding this comment.
Thanks for all the updates @enavarro51 , and for working out all the edge cases. Few small comments, then this looks good to go.
kdk
approved these changes
Aug 3, 2021
kdk
added
Changelog: New Feature
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6493
Details and comments
This PR replaces the
qiskit.dagcircuit.DAGNodeclass with 3 classes -OpNode, InNode, and OutNode- and turnsDAGNodeinto the parent of the 3 classes. Thetype,op, andwirekwargs to DAGNode have been deprecated.