-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ScipyMilpOptimizer #496
Conversation
# Conflicts: # qiskit_optimization/algorithms/__init__.py # setup.py
Pull Request Test Coverage Report for Build 4932946655
💛 - Coveralls |
Since we run coverage along with the other checks under 3.7 and this new code is not supported in that version this would explain the coverage drop. In Nature I had already bumped the checks to run under 3.8 - since we build/deploy docs under 3.8 and we build a documentation zip as part of the checks. I had bumped it since 3.7 is nearing EOL and I wanted to ensure that what I was seeing in the docs was indeed the same as what we published. This is a simple one line change and could be done in a separate PR to check things out - then once the branch is updated here we would get a better idea of the coverage of this new code. |
Thank you for your information. I will bump Python version for the check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 100% test coverage of the ScipyMilpOptimzer - nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Adds
ScipyMilpOptimizer
based on Scipy's MILP solver.Scipy introduced MILP solver since 1.9.0 (supports Python 3.8 or newer).
supersedes #447
This PR is a QAMP 22 fall project by @Dran-Z qiskit-advocate/qamp-fall-22#2
Details and comments
update requirements.txt?