Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session.from_id() shouldn't accept max_time #1134

Closed
2 tasks
jyu00 opened this issue Oct 5, 2023 · 1 comment · Fixed by #1137
Closed
2 tasks

Session.from_id() shouldn't accept max_time #1134

jyu00 opened this issue Oct 5, 2023 · 1 comment · Fixed by #1137
Assignees
@kt474
Labels
enhancement New feature or request
Milestone
0.13.0

Comments

@jyu00
Copy link
Collaborator

jyu00 commented Oct 5, 2023

What is the expected feature or enhancement?

#1101 added a from_id() method to Session. It takes in a max_time parameter, which is misleading because you cannot change a session max_time after it's created (and it has to have been created to have an id).

In addition, this method doesn't have docstring on the parameters.

Acceptance criteria

  • Remove max_time from from_id()
  • Explain what parameters are in the docstring
@jyu00 jyu00 added the enhancement New feature or request label Oct 5, 2023
@kt474 kt474 self-assigned this Oct 8, 2023
@kt474 kt474 mentioned this issue Oct 8, 2023
Merged
@jyu00
Copy link
Collaborator Author

jyu00 commented Oct 9, 2023

Note that backend should also be removed once session details can be queried.

@kt474 kt474 added this to the 0.13.0 milestone Oct 9, 2023
@kt474 kt474 mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kt474 kt474

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Update docstring & remove max_time in from_id() kt474/qiskit-ibm-runtime
2 participants
@kt474 @jyu00