Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Support session #699

Merged
merged 61 commits into from
Aug 23, 2023
Merged

Support session #699

merged 61 commits into from
Aug 23, 2023

Conversation

merav-aharoni
Copy link
Collaborator

@merav-aharoni merav-aharoni commented Aug 10, 2023

Summary

Adding support for Session in qiskit-ibm-provider.

Details and comments

A _session member was added to IBMBackend.
This update introduces duplications between this repo and qiskit-ibm-runtime. They should be addressed after this one is merged. See related issue: Qiskit/qiskit-ibm-runtime#969.
Fixes #588.

@merav-aharoni merav-aharoni changed the title Support session in backend Support session Aug 13, 2023
@merav-aharoni
Copy link
Collaborator Author

We also need to update the relevant tutorial. I prefer to do this in a separate PR, so that we first finalize the implementation details here.

@merav-aharoni merav-aharoni marked this pull request as ready for review August 13, 2023 11:15
@merav-aharoni merav-aharoni requested review from jyu00 and kt474 and removed request for kt474 August 13, 2023 11:15
@coveralls
Copy link

coveralls commented Aug 20, 2023

Pull Request Test Coverage Report for Build 5941017993

  • 64 of 94 (68.09%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 51.349%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/api/clients/runtime.py 1 2 50.0%
qiskit_ibm_provider/api/rest/runtime.py 2 3 66.67%
qiskit_ibm_provider/api/rest/runtime_session.py 8 11 72.73%
qiskit_ibm_provider/utils/converters.py 9 14 64.29%
qiskit_ibm_provider/session.py 23 32 71.88%
qiskit_ibm_provider/ibm_backend.py 19 30 63.33%
Totals Coverage Status
Change from base Build 5940147572: 0.2%
Covered Lines: 3368
Relevant Lines: 6559

💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Aug 21, 2023
@merav-aharoni
Copy link
Collaborator Author

merav-aharoni commented Aug 22, 2023

I made a few additional changes since your last review:

  1. Added/modified checks inside the tests following your comment above.
  2. Added handling of session_id in IBM_Job. I noticed this was missing while doing (1).
  3. Added the new test file to integration-test-3 in the Makefile.

I think this will require an additional review.

@kt474 kt474 merged commit 661e301 into Qiskit:main Aug 23, 2023
@merav-aharoni merav-aharoni deleted the session_in_backend branch August 28, 2023 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support session
3 participants