Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Add CompletenessChecking for Fetch/Push services #4

Open
tomcoldrick-ct opened this issue Aug 11, 2020 · 0 comments
Open

Add CompletenessChecking for Fetch/Push services #4

tomcoldrick-ct opened this issue Aug 11, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomcoldrick-ct
Copy link
Collaborator

Currently we naïvely assume that the blobs referenced in requests/responses exist in CAS without checking. We should add something analogous to the CompletenessCheckingBlobAccess to ensure that blobs we reference actually exist.

One thing to be careful of while implementing this is that PushBlob and PushDirectory requests contain an additional pair of digest lists which we will also need to ensure exist. Given this, we'll need to add an extra field (or two, if we want to distinguish between Blob/Directory) to the Asset proto to store these digests so we can check at push and fetch time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants