Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERLIS export VSA-DSS fails if organisation subclasses are not added #116

Closed
sjib opened this issue Mar 31, 2023 · 3 comments
Closed

INTERLIS export VSA-DSS fails if organisation subclasses are not added #116

sjib opened this issue Mar 31, 2023 · 3 comments
Assignees
@sjib
Labels
enhancement New feature or request

Comments

@sjib
Copy link
Contributor

sjib commented Mar 31, 2023

The VSA-DSS model has subclasses for the class organisation. If they are not set INTERLIS export fails with cryptic error message:
20230329_qgep_export_dss_betreiber_ref_1_nicht_in_tabelle_organisation_wegen_fehlender_subklassseneintraegen
@sjib sjib added the enhancement New feature or request label Mar 31, 2023
@sjib sjib self-assigned this Mar 31, 2023
@sjib
Copy link
Contributor Author

sjib commented Mar 31, 2023

Idea: Add integrity check like in this function count_element_qgep_od_organisation:
create_vsa_dss_2015_2_d.count_element_qgep_od.zip

If number of subclass elements is not equal organisation elements check fails, elese ok:
20230331_organisation_integrity_check

@sjib sjib mentioned this issue Mar 31, 2023
Merged
@sjib
Copy link
Contributor Author

sjib commented Mar 31, 2023

Implementation see:

qgepqwat2ili/qgepqwat2ili/utils/ili2db.py

Line 9 in 4636621

# Checking if subclass entries of organisation are set and match number of organisatin entries

@sjib
Copy link
Contributor Author

sjib commented Mar 31, 2023

A similar check could be done for missing identifiers (see also #90)
@kandre What do you think?

@sjib sjib mentioned this issue Mar 31, 2023
Closed
@sjib sjib mentioned this issue Dec 14, 2023
Closed
@sjib sjib mentioned this issue Jan 17, 2024
Open
@sjib sjib closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjib sjib

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjib