Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] pre-commit with ruff,codespell,yamlint #681

Merged
merged 12 commits into from
Oct 31, 2024
Merged

[MRG] pre-commit with ruff,codespell,yamlint #681

merged 12 commits into from
Oct 31, 2024

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Oct 30, 2024

Types of changes

This very large PR introduce a new style for the coe thta follow ruff formating with a fats pre-commit that will hopfully avoid "pep8" cmmts in the PRs in the future

Currently implements:

  • Ruff Lint (for main code and tetss/exmaples and doc)
  • Codespell (found many typos)
  • yamllint

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@rflamary rflamary changed the title [WIP] pre-commit with ruff,codespell,yamlint [MRG] pre-commit with ruff,codespell,yamlint Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 94.09449% with 45 lines in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (ea841c7) to head (3ecba65).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   97.06%   97.03%   -0.04%     
==========================================
  Files          98       98              
  Lines       19638    19639       +1     
==========================================
- Hits        19061    19056       -5     
- Misses        577      583       +6     

@rflamary rflamary merged commit 38922c0 into master Oct 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant