[MRG] Only Minkowski metrics can be used for emd_1d #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
The point here is to prevent anyone from using the
emd_1d
andemd2_1d
functions with metrics that are not Minkowski ones, since this implementation is valid only in this case.As such, I have left the opportunity to use
'sqeuclidean'
,'minkowski'
,'cityblock'
, or'euclidean'
as metrics. Another option would be to remove themetrics
keyword and only specifyp
, but that would break backward compatibility, so I assumed this change was better for maintenance purposes. Let me know if this should be changed.Motivation and context / Related issue
This PR aims at solving issue #669.
How has this been tested (if it applies)
Not tested yet.
PR checklist