Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to Embed #1995

Closed
davidhozic opened this issue Apr 2, 2023 · 0 comments · Fixed by #1996
Closed

Add missing parameters to Embed #1995

davidhozic opened this issue Apr 2, 2023 · 0 comments · Fixed by #1996
Labels
feature request New feature request

Comments

@davidhozic
Copy link
Contributor

davidhozic commented Apr 2, 2023

Summary

Related PR: #1996

The Embed is missing some parameters.

What is the feature request for?

The core library

The Problem

Currently the Embed object doesn't accept all the parameters at start and instead set's some of them through functions:

  • Embed.set_footer,
  • Embed.set_image and
  • Embed.set_thumbnail

which requires extra work to define it and is a bit unpractical.

Additionaly, for some reason, discord.types.embed.Embed defines these parameters in the annotations which makes it seem like they were planned, but never realized.

The Ideal Solution

I propose to allow definition of these parameters at Embed definition.

The Current Solution

No response

Additional Context

No response

@davidhozic davidhozic added the feature request New feature request label Apr 2, 2023
@davidhozic davidhozic changed the title feat: Add missing parameters to Embed Add missing parameters to Embed Apr 2, 2023
@Lulalaby Lulalaby linked a pull request Apr 2, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant