-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate GPUStatsMonitor
and XLAStatsMonitor
in favor of DeviceStatsMonitor
#9924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellepintz
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 14, 2021 06:09
for more information, see https://pre-commit.ci
12 tasks
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9924 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15745 15780 +35
=======================================
- Hits 14597 14010 -587
- Misses 1148 1770 +622 |
tchaton
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Great work !
rohitgr7
reviewed
Oct 14, 2021
rohitgr7
approved these changes
Oct 14, 2021
kaushikb11
approved these changes
Oct 14, 2021
SkafteNicki
reviewed
Oct 14, 2021
Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
rohitgr7
added a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
…StatsMonitor` (Lightning-AI#9924) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates
GPUStatsMonitor
andXLAStatsMonitor
, as they can now be replaced by theDeviceStatsMonitor
which callsget_device_stats
on the Accelerator interface.Part of #9032
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃