Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ModuleNotFoundError instead of ImportError #9867

Merged
merged 3 commits into from
Oct 11, 2021
Merged

use ModuleNotFoundError instead of ImportError #9867

merged 3 commits into from
Oct 11, 2021

Conversation

sidml
Copy link
Contributor

@sidml sidml commented Oct 8, 2021

What does this PR do?

Use ModuleNotFoundError instead of ImportError for consistency

Fixes #9556

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this! please update the changelog with this PR

@ananthsub ananthsub added this to the v1.5 milestone Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #9867 (a0dcb41) into master (5206e52) will decrease coverage by 4%.
The diff coverage is 62%.

@@           Coverage Diff           @@
##           master   #9867    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         178     178            
  Lines       15620   15620            
=======================================
- Hits        14477   13868   -609     
- Misses       1143    1752   +609     

@mergify mergify bot added the ready PRs ready to be merged label Oct 9, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) October 10, 2021 19:28
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidml LGTM! Thank you for your contribution :]

@awaelchli awaelchli merged commit c395766 into Lightning-AI:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] Use ModuleNotFoundError instead of ImportError for consistency
5 participants