-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ModuleNotFoundError instead of ImportError #9867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this! please update the changelog with this PR
Codecov Report
@@ Coverage Diff @@
## master #9867 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 178 178
Lines 15620 15620
=======================================
- Hits 14477 13868 -609
- Misses 1143 1752 +609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sidml LGTM! Thank you for your contribution :]
What does this PR do?
Use ModuleNotFoundError instead of ImportError for consistency
Fixes #9556
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃