Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused post_optimizer_step #9746

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 29, 2021

What does this PR do?

No public usage: https://grep.app/search?q=post_optimizer_step&filter[lang][0]=Python
Part of #9287. This hook will have no real use after the optimizer step is moved to the precision plugin.

Does your PR introduce any breaking changes? If yes, please list them.

Removes the post_optimizer_step hook.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor breaking change Includes a breaking change labels Sep 29, 2021
@carmocca carmocca added this to the v1.5 milestone Sep 29, 2021
@carmocca carmocca self-assigned this Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #9746 (f804677) into master (019e69f) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9746   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         177     177           
  Lines       15389   15384    -5     
======================================
- Hits        14263   14258    -5     
  Misses       1126    1126           

@mergify mergify bot added the ready PRs ready to be merged label Sep 29, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! quick note: It could be used for federate learning to broadcast cast the updated weights.

@tchaton tchaton enabled auto-merge (squash) September 29, 2021 08:23
@carmocca carmocca enabled auto-merge (squash) September 29, 2021 12:52
@carmocca carmocca merged commit 9ebfbbc into master Sep 29, 2021
@carmocca carmocca deleted the refactor/remove-post-optimizer-step branch September 29, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants