Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add Fault Tolerant Training for ValidationLoop. #9563

Merged
merged 66 commits into from
Sep 24, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 16, 2021

What does this PR do?

Lightning 1.5 is going to introduce Fault Tolerant feature.
However, the feature is still requires some improvements. As a matter of fact, Lightning doesn't support to be restarted within the ValidationLoop yet.

Part of #9130

Fixes #9564

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

pytorch_lightning/loops/epoch/training_epoch_loop.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
@carmocca carmocca assigned carmocca and unassigned tchaton Sep 23, 2021
@carmocca carmocca marked this pull request as draft September 23, 2021 12:31
@carmocca carmocca mentioned this pull request Sep 24, 2021
11 tasks
@carmocca carmocca changed the base branch from master to feat/support-skipping-to-val September 24, 2021 05:37
@carmocca carmocca marked this pull request as ready for review September 24, 2021 05:41
@mergify mergify bot removed the has conflicts label Sep 24, 2021
@carmocca carmocca marked this pull request as draft September 24, 2021 05:41
Base automatically changed from feat/support-skipping-to-val to master September 24, 2021 14:10
@carmocca carmocca marked this pull request as ready for review September 24, 2021 14:19
@carmocca carmocca mentioned this pull request Sep 24, 2021
38 tasks
@carmocca carmocca enabled auto-merge (squash) September 24, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Add support for fault tolerance within the ValidationLoop
6 participants