-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add_argparse_args
raising TypeError
with Python 3.6
#9554
Conversation
for more information, see https://pre-commit.ci
…torch-lightning into bugfix/argparse-py36
add_argparse_args
raising TypeError
with Python 3.6add_argparse_args
raising TypeError
with Python 3.6
add_argparse_args
raising TypeError
with Python 3.6add_argparse_args
raising TypeError
with Python 3.6
Codecov Report
@@ Coverage Diff @@
## master #9554 +/- ##
======================================
Coverage 93% 93%
======================================
Files 180 180
Lines 15090 15090
======================================
Hits 14019 14019
Misses 1071 1071 |
add_argparse_args
raising TypeError
with Python 3.6add_argparse_args
raising TypeError
with Python 3.6
The failing tests are irrelevant to the changes made here. Also, DeepSource is complaining that but a test class above also doesn't contain any code in so I believe this PR is ready for your review now. |
* Add test * Accept TypeError for arg_type.__args__ being None Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add test * Accept TypeError for arg_type.__args__ being None Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add test * Accept TypeError for arg_type.__args__ being None Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add test * Accept TypeError for arg_type.__args__ being None Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add test * Accept TypeError for arg_type.__args__ being None Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
Fixes #9535.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃