Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing deepspeed distributed call #9540

Merged
merged 7 commits into from
Sep 17, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 15, 2021

What does this PR do?

Related #9521

After #9044 DeepSpeed was not updated to use the overridden function init_ddp_connection. I've refactored the code such that DeepSpeed handles the necessary initialisation.

As noted by Adrian, #9044 was not included in 1.4.x, so this will be a fix for 1.5

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Sep 15, 2021
@SeanNaren SeanNaren self-assigned this Sep 15, 2021
@SeanNaren SeanNaren added this to the v1.4.x milestone Sep 15, 2021
@SeanNaren SeanNaren added the 3rd party Related to a 3rd-party label Sep 15, 2021
@mergify mergify bot removed the has conflicts label Sep 15, 2021
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2021
@SeanNaren SeanNaren modified the milestones: v1.4.x, v1.5 Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #9540 (be965ae) into master (2ec39e2) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9540    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         181     181            
  Lines       15159   15173    +14     
=======================================
+ Hits        13469   14097   +628     
+ Misses       1690    1076   -614     

@SeanNaren SeanNaren enabled auto-merge (squash) September 17, 2021 14:43
@ananthsub
Copy link
Contributor

@SeanNaren @tchaton would you be in favor of making deepspeed plug-in inherit from ParallelPlugin directly? Flattening the inheritance structure reduces the risk of bugs like this

@SeanNaren SeanNaren merged commit 77c719f into master Sep 17, 2021
@SeanNaren SeanNaren deleted the fix/deepspeed_initialize branch September 17, 2021 16:57
SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants