Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom logic to each OutputResult subclass [2/2] #9424

Merged
merged 53 commits into from
Sep 15, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 9, 2021

What does this PR do?

Follow-up to #9349

  • Treat everything returned by the manual optimization training_step as an "extra".
  • Customize ManualResult logic.
  • Tighten output validation.
  • Integrate output validation into the appropriate result class.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 14, 2021
@carmocca carmocca changed the title [WIP] Add OutputResult [2/2] Add custom logic to each OutputResult subclass [2/2] Sep 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Sep 15, 2021
@carmocca carmocca enabled auto-merge (squash) September 15, 2021 00:49
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #9424 (fc91d13) into master (5735b85) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9424    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     180            
  Lines       15105   15090    -15     
=======================================
- Hits        14031   13404   -627     
- Misses       1074    1686   +612     

@carmocca carmocca merged commit 23450e2 into master Sep 15, 2021
@carmocca carmocca deleted the refactor/poc-output-result branch September 15, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants