Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal/1.5 lightning module datamodule property #9233

Conversation

Tshimanga
Copy link
Contributor

@Tshimanga Tshimanga commented Aug 31, 2021

What does this PR do?

Removal of datamodule property from LightningModule as scheduled for 1.5

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #9233 (5ee1c63) into master (ccc83e7) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9233    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         176     176            
  Lines       14810   14801     -9     
=======================================
- Hits        13662   13042   -620     
- Misses       1148    1759   +611     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up for @ethanwharris as I believe Flash relies on this

@mergify mergify bot added the has conflicts label Sep 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Sep 1, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 1, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @Tshimanga wants to make a PR to flash as well 😃

@awaelchli awaelchli merged commit 35876bb into Lightning-AI:master Sep 1, 2021
@Tshimanga Tshimanga deleted the removal/1.5-lightning-module-datamodule-property branch September 2, 2021 02:39
@Tshimanga
Copy link
Contributor Author

maybe @Tshimanga wants to make a PR to flash as well smiley

@awaelchli @ethanwharris yeah I can take care of that. Probably won't be able to get around to it till Tues (9/7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants