-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal/1.5 lightning module datamodule property #9233
Removal/1.5 lightning module datamodule property #9233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9233 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 176
Lines 14810 14801 -9
=======================================
- Hits 13662 13042 -620
- Misses 1148 1759 +611 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heads up for @ethanwharris as I believe Flash relies on this
…lightning into removal/1.5-lightning-module-datamodule-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
…lightning into removal/1.5-lightning-module-datamodule-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe @Tshimanga wants to make a PR to flash as well 😃
@awaelchli @ethanwharris yeah I can take care of that. Probably won't be able to get around to it till Tues (9/7) |
What does this PR do?
Removal of datamodule property from
LightningModule
as scheduled for 1.5Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃