deprecate on_{train/val/test/predict}_dataloader() from DataHooks
#9098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninginthecloud
requested review from
ananthsub,
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
ananthsub
suggested changes
Aug 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #9098 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 176
Lines 14804 14828 +24
=======================================
- Hits 13651 13056 -595
- Misses 1153 1772 +619 |
ananthsub
changed the title
on_{train/val/test/predict}_trainer() from DataHookson_{train/val/test/predict}_dataloader() from DataHooks
ananthsub
reviewed
Aug 25, 2021
pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py
Outdated
Show resolved
Hide resolved
tchaton
reviewed
Aug 25, 2021
awaelchli
approved these changes
Aug 25, 2021
Summary:
1. remove `on_{train/val/test/predict}_dataloader()`
2. update corrsonding tests
Test Plan:
make test
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: 1. check overridden in configuration_validator.py 2. add unit test to catch deprecation warning 3. update hooks docstring Test Plan: Reviewers: Subscribers: Tasks: Tags:
for more information, see https://pre-commit.ci
ninginthecloud
force-pushed
the
deprecation/8758_on_train_dataloader
branch
from
8dc7a89
to
29474af
Compare
ninginthecloud
force-pushed
the
deprecation/8758_on_train_dataloader
branch
from
2c35b67
to
c2e046c
Compare
ananthsub
approved these changes
Aug 27, 2021
|
Hey @ananthsub @ninginthecloud, Let's wait a little for this one. I want to make sure we can find an alternative for Flash as those hooks are currently the cleanest way to modify in-place dataloaders on reset. @ethanwharris Mind looking into this ? Best, |
Co-authored-by: ananthsub <[email protected]>
ethanwharris
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
LGTM, flash is no longer dependent on this following: Lightning-Universe/lightning-flash#707
Co-authored-by: ananthsub <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Context
Fixes #8758
DataHooks has defined
on_{train/val/test/predict}_dataloader, but these functions ususally are called right before{train/val/test/predict}_dataloader. It's difficult for users to distinguish these two sets of hooks. As discussed in issue #8758 (detailed discussion here), it's aligned that we can deprecate this set of hooks.Steps
on_{train/val/test/predict}_dataloaderfrom DataHookstest_dataloaders.pyandtest_hooks.pyfx_validator.pyDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃