Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightningCLI save config multifile option required to support save to fsspec filesystem #9073

Merged
merged 7 commits into from
Sep 23, 2021
Merged

LightningCLI save config multifile option required to support save to fsspec filesystem #9073

merged 7 commits into from
Sep 23, 2021

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Aug 24, 2021

What does this PR do?

jsonargparse now supports saving config to fsspec filesystem. This is a necessary change for it to work by default.

Fixes #8843

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #9073 (409be39) into master (856ed10) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9073    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         181     181            
  Lines       15295   15297     +2     
=======================================
- Hits        14211   13596   -615     
- Misses       1084    1701   +617     

@mauvilsa mauvilsa changed the title LightningCLI support save to fsspec file LightningCLI support save to fsspec filesystem Aug 24, 2021
@carmocca carmocca added argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement labels Aug 24, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 24, 2021
@carmocca
Copy link
Contributor

Is this still a draft?

@mauvilsa
Copy link
Contributor Author

Is this still a draft?

I was waiting for @thecooltechguy to try it out and forgot about it. Will change it to ready for review.

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/utilities/cli.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2021
@mauvilsa mauvilsa changed the title LightningCLI support save to fsspec filesystem LightningCLI save config multifile option required to support save to fsspec filesystem Sep 17, 2021
@mergify mergify bot removed the has conflicts label Sep 17, 2021
@carmocca carmocca enabled auto-merge (squash) September 17, 2021 20:03
@carmocca carmocca merged commit eb6aa7a into Lightning-AI:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaveConfigCallback errors out when default_root_dir is an S3 path
4 participants