-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningCLI save config multifile option required to support save to fsspec filesystem #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9073 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 181 181
Lines 15295 15297 +2
=======================================
- Hits 14211 13596 -615
- Misses 1084 1701 +617 |
mauvilsa
changed the title
LightningCLI support save to fsspec file
LightningCLI support save to fsspec filesystem
Aug 24, 2021
carmocca
added
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
feature
Is an improvement or enhancement
labels
Aug 24, 2021
Is this still a draft? |
I was waiting for @thecooltechguy to try it out and forgot about it. Will change it to ready for review. |
mauvilsa
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 17, 2021 06:33
awaelchli
approved these changes
Sep 17, 2021
Borda
reviewed
Sep 17, 2021
carmocca
approved these changes
Sep 17, 2021
mauvilsa
changed the title
LightningCLI support save to fsspec filesystem
LightningCLI save config multifile option required to support save to fsspec filesystem
Sep 17, 2021
Borda
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
jsonargparse now supports saving config to fsspec filesystem. This is a necessary change for it to work by default.
Fixes #8843
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃