-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update an outdated error message in DDPPlugin #9005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9005 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 175 175
Lines 14466 14463 -3
=======================================
- Hits 13414 12812 -602
- Misses 1052 1651 +599 |
SkafteNicki
approved these changes
Aug 20, 2021
carmocca
approved these changes
Aug 20, 2021
ananthsub
approved these changes
Aug 20, 2021
kaushikb11
reviewed
Aug 23, 2021
awaelchli
commented
Aug 23, 2021
Co-authored-by: Kaushik B <[email protected]>
kaushikb11
reviewed
Aug 23, 2021
Co-authored-by: Kaushik B <[email protected]>
tchaton
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distributed
Generic distributed-related topic
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8998
Replaces an outdated error message saying that fit() is not allowed to be called multiple time.
The new error message addresses a assertion error with a friendly message with possible causes of the malfunction.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃