Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update an outdated error message in DDPPlugin #9005

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 19, 2021

What does this PR do?

Fixes #8998

Replaces an outdated error message saying that fit() is not allowed to be called multiple time.
The new error message addresses a assertion error with a friendly message with possible causes of the malfunction.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added distributed Generic distributed-related topic feature Is an improvement or enhancement labels Aug 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #9005 (b2ef688) into master (e9ce598) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9005    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         175     175            
  Lines       14466   14463     -3     
=======================================
- Hits        13414   12812   -602     
- Misses       1052    1651   +599     

@awaelchli awaelchli marked this pull request as ready for review August 20, 2021 08:51
@mergify mergify bot added the ready PRs ready to be merged label Aug 20, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 21, 2021 20:16
@mergify mergify bot removed the has conflicts label Aug 23, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli merged commit 49c52b0 into master Aug 23, 2021
@awaelchli awaelchli deleted the feature/warn-ddp-spawn branch August 23, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launching ddp fails with assertion error
6 participants