Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3/n integrate new LightningDataFetcher into loop #8953

Merged
merged 54 commits into from
Aug 17, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 17, 2021

What does this PR do?

Follow up to #8891
Integrates the fetcher into the training loop. Originally introducded in #8890 (with tests)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Base automatically changed from add_lightning_prefetcher_2_n to master August 17, 2021 16:32
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #8953 (708df73) into master (19136ac) will increase coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #8953   +/-   ##
======================================
  Coverage      88%     89%           
======================================
  Files         176     176           
  Lines       14394   14402    +8     
======================================
+ Hits        12695   12763   +68     
+ Misses       1699    1639   -60     

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2021
@tchaton tchaton enabled auto-merge (squash) August 17, 2021 21:25
@tchaton tchaton merged commit 522df2b into master Aug 17, 2021
@tchaton tchaton deleted the thomas/integrate-fetcher branch August 17, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants