Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/n] Add LightningFetcher #8890

Merged
merged 13 commits into from
Aug 16, 2021
Merged

[1/n] Add LightningFetcher #8890

merged 13 commits into from
Aug 16, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 13, 2021

What does this PR do?

This PR introduce the LightningFetcher.

Next PR will add fault tolerant training components.

Parts of #8867

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #8890 (92abd0e) into master (e060547) will increase coverage by 4%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #8890    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         172     173     +1     
  Lines       14178   14182     +4     
=======================================
+ Hits        12568   13174   +606     
+ Misses       1610    1008   -602     

pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
@carmocca
Copy link
Contributor

Is there some bigger picture somewhere of how this is going to be used, what will this replace, and how will users interact with or override it?

@tchaton
Copy link
Contributor Author

tchaton commented Aug 14, 2021

Is there some bigger picture somewhere of how this is going to be used, what will this replace, and how will users interact with or override it?

Hey @carmocca, yes definitely.

The LightningFetcher was introduced through this RFCs: #8867 and will be used to replace the prefetch_function. This should also be used for validation purposes.

There is a long way before we make this object public API, however it is there to solve 3 primary issues:

Best,
T.C

@tchaton tchaton requested a review from SeanNaren August 16, 2021 09:59
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mergify mergify bot added the ready PRs ready to be merged label Aug 16, 2021
@tchaton tchaton enabled auto-merge (squash) August 16, 2021 13:07
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/fetching.py Outdated Show resolved Hide resolved
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@tchaton tchaton merged commit 89156b7 into master Aug 16, 2021
@tchaton tchaton deleted the add_lightning_prefetcher branch August 16, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants