-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/n] Add LightningFetcher #8890
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8890 +/- ##
=======================================
+ Coverage 89% 93% +4%
=======================================
Files 172 173 +1
Lines 14178 14182 +4
=======================================
+ Hits 12568 13174 +606
+ Misses 1610 1008 -602 |
Is there some bigger picture somewhere of how this is going to be used, what will this replace, and how will users interact with or override it? |
Hey @carmocca, yes definitely. The LightningFetcher was introduced through this RFCs: #8867 and will be used to replace the There is a long way before we make this object public API, however it is there to solve 3 primary issues:
Best, |
…Lightning/pytorch-lightning into add_lightning_prefetcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
This PR introduce the LightningFetcher.
Next PR will add fault tolerant training components.
Parts of #8867
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃