-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save the ResultCollection
in the loops state dict
#8641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8641 +/- ##
======================================
Coverage 93% 93%
======================================
Files 167 167
Lines 13960 13999 +39
======================================
+ Hits 12928 12968 +40
+ Misses 1032 1031 -1 |
Hello @tchaton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-02 19:57:06 UTC |
for more information, see https://pre-commit.ci
…ightning/pytorch-lightning into add_support_for_logging
for more information, see https://pre-commit.ci
…ightning/pytorch-lightning into add_support_for_logging
Co-authored-by: Adrian Wälchli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
This PR adds support for
loading / restoring ResultCollection
automatically with multiple processes from the state_dict.Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃