Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the ResultCollection in the loops state dict #8641

Merged
merged 35 commits into from
Aug 2, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 30, 2021

What does this PR do?

This PR adds support for loading / restoring ResultCollection automatically with multiple processes from the state_dict.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton changed the title [feat] Add ResultCollection state_dict to loops [wip] Add ResultCollection state_dict to loops Jul 30, 2021
@tchaton tchaton self-assigned this Jul 30, 2021
@tchaton tchaton added this to the v1.5 milestone Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #8641 (923c74b) into master (15fb320) will increase coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff           @@
##           master   #8641   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         167     167           
  Lines       13960   13999   +39     
======================================
+ Hits        12928   12968   +40     
+ Misses       1032    1031    -1     

@pep8speaks
Copy link

pep8speaks commented Jul 30, 2021

Hello @tchaton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 216:17: W503 line break before binary operator
Line 217:17: W503 line break before binary operator

Comment last updated at 2021-08-02 19:57:06 UTC

@tchaton tchaton added the design Includes a design discussion label Jul 30, 2021
@tchaton tchaton marked this pull request as ready for review July 30, 2021 11:29
@carmocca carmocca changed the title [wip] Add ResultCollection state_dict to loops Add ResultCollection state_dict to loops Jul 30, 2021
pytorch_lightning/plugins/training_type/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/base.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/base.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Aug 1, 2021
@mergify mergify bot removed the has conflicts label Aug 1, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@tchaton tchaton enabled auto-merge (squash) August 2, 2021 13:14
@tchaton tchaton disabled auto-merge August 2, 2021 13:14
@tchaton tchaton enabled auto-merge (squash) August 2, 2021 13:15
@mergify mergify bot added the has conflicts label Aug 2, 2021
@mergify mergify bot removed the has conflicts label Aug 2, 2021
@tchaton tchaton merged commit dd8216a into master Aug 2, 2021
@tchaton tchaton deleted the add_support_for_logging branch August 2, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants