-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch_size
, rank_zero_only
arguments for log_dict
to match log
#8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladsegal
requested review from
awaelchli,
tchaton and
williamFalcon
as code owners
July 29, 2021 17:56
Codecov Report
@@ Coverage Diff @@
## master #8628 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 167 167
Lines 14037 14037
=======================================
- Hits 13008 12453 -555
- Misses 1029 1584 +555 |
awaelchli
added
logging
Related to the `LoggerConnector` and `log()`
feature
Is an improvement or enhancement
labels
Jul 29, 2021
awaelchli
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaton does this look good to you?
eladsegal
changed the title
Add rank_zero_only argument for log_dict
Add batch_size, rank_zero_only argument for log_dict
Jul 31, 2021
eladsegal
changed the title
Add batch_size, rank_zero_only argument for log_dict
Add Jul 31, 2021
batch_size
, rank_zero_only
arguments for log_dict
to match log
eladsegal
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
SeanNaren
as code owners
July 31, 2021 01:08
tchaton
approved these changes
Jul 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
approved these changes
Aug 2, 2021
awaelchli
approved these changes
Aug 2, 2021
Borda
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#7966 added
rank_zero_only
argument for thelog
function, but it should be added tolog_dict
as well.Also,
batch_size
is missing and can be added.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃