Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch_size, rank_zero_only arguments for log_dict to match log #8628

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

eladsegal
Copy link
Contributor

@eladsegal eladsegal commented Jul 29, 2021

What does this PR do?

#7966 added rank_zero_only argument for the log function, but it should be added to log_dict as well.
Also, batch_size is missing and can be added.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8628 (4a1e350) into master (98319f8) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8628    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         167     167            
  Lines       14037   14037            
=======================================
- Hits        13008   12453   -555     
- Misses       1029    1584   +555     

@awaelchli awaelchli added logging Related to the `LoggerConnector` and `log()` feature Is an improvement or enhancement labels Jul 29, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton does this look good to you?

pytorch_lightning/core/lightning.py Show resolved Hide resolved
@eladsegal eladsegal changed the title Add rank_zero_only argument for log_dict Add batch_size, rank_zero_only argument for log_dict Jul 31, 2021
@eladsegal eladsegal changed the title Add batch_size, rank_zero_only argument for log_dict Add batch_size, rank_zero_only arguments for log_dict to match log Jul 31, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton added the ready PRs ready to be merged label Jul 31, 2021
@carmocca carmocca modified the milestones: v1.4.x, v1.5 Aug 2, 2021
@tchaton tchaton enabled auto-merge (squash) August 2, 2021 17:55
@mergify mergify bot added the has conflicts label Aug 3, 2021
@mergify mergify bot removed the has conflicts label Aug 3, 2021
@tchaton tchaton merged commit 08fba96 into Lightning-AI:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants