Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate total_batch_idx with progress tracking #8598

Merged
merged 9 commits into from
Aug 14, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Jul 28, 2021
@carmocca carmocca self-assigned this Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #8598 (014a4e4) into master (b47e3ab) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8598   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         169     169           
  Lines       14061   14077   +16     
======================================
+ Hits        13033   13051   +18     
+ Misses       1028    1026    -2     

@awaelchli awaelchli self-requested a review July 29, 2021 01:30
@mergify mergify bot removed the has conflicts label Jul 29, 2021
@carmocca carmocca marked this pull request as draft July 29, 2021 13:03
@carmocca carmocca mentioned this pull request Aug 11, 2021
11 tasks
@carmocca carmocca marked this pull request as ready for review August 11, 2021 21:09
@carmocca carmocca requested a review from tchaton August 12, 2021 00:53
@mergify mergify bot added the ready PRs ready to be merged label Aug 13, 2021
@carmocca carmocca merged commit 0aa5cc7 into master Aug 14, 2021
@carmocca carmocca deleted the refactor/total-batch-idx branch August 14, 2021 12:08
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants