Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum PyTorch version to 1.6 #8288

Merged
merged 10 commits into from
Jul 13, 2021
Merged

Set minimum PyTorch version to 1.6 #8288

merged 10 commits into from
Jul 13, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 5, 2021

What does this PR do?

See title.

TODO: Make sure the "Current build statuses" table in the README is correct

Screenshot 2021-07-05 at 14 11 03

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added the ci Continuous Integration label Jul 5, 2021
@carmocca carmocca added this to the v1.4 milestone Jul 5, 2021
@carmocca carmocca self-assigned this Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #8288 (1e6c18f) into master (1efd6d2) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8288   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         216     216           
  Lines       14123   14115    -8     
======================================
- Hits        13095   13019   -76     
- Misses       1028    1096   +68     

@tchaton
Copy link
Contributor

tchaton commented Jul 6, 2021

Hey @ananthsub,
Would you mind to validate there is no specific reason for Lightning to keep supporting 1.4 and 1.5 ?

@ananthsub
Copy link
Contributor

ananthsub commented Jul 8, 2021

Would you mind to validate there is no specific reason for Lightning to keep supporting 1.4 and 1.5 ?

As discussed today, this is primarily motivated by how long the backward-compatibility window ought to be. Users can always pin themselves to older versions of Lightning if they absolutely need older PyTorch support. Given how stable the PyTorch API has been, there's less risk of breaking changes across these versions that Lightning needs to cover for. However there are a ton of features users will get with both PyTorch and Lightning by updating to recent versions. Plus CI time/$ savings for contributors, but this is a minor concern compared to user adoption.

@carmocca @Borda if you want to be more conservative, we could start with not supporting PyTorch v1.4, see how the community receives this, and then determine if this is a pattern we can continue for the next releases (e.g. always support the latest N releases of PyTorch, or PyTorch versions within last T time).

@Borda
Copy link
Member

Borda commented Jul 8, 2021

we could start with not supporting PyTorch v1.4, see how the community receives this

I may say that with adding support for future PT 1.10 #8133 we can do a bit bigger step and drop also PT 1.5 for the upcoming PL 1.4 (so we would have still 5 minor PT support)

@tchaton
Copy link
Contributor

tchaton commented Jul 8, 2021

we could start with not supporting PyTorch v1.4, see how the community receives this

I may say that with adding support for future PT 1.10 #8133 we can do a bit bigger step and drop also PT 1.5 for the upcoming PL 1.4 (so we would have still 5 minor PT support)

Yes, I think it is a good approach.

@Borda Borda marked this pull request as ready for review July 9, 2021 13:42
@mergify mergify bot added the has conflicts label Jul 9, 2021
@Borda Borda added the ready PRs ready to be merged label Jul 9, 2021
@mergify mergify bot removed the has conflicts label Jul 9, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.3.x Jul 9, 2021
@Borda Borda enabled auto-merge (squash) July 9, 2021 20:31
@carmocca carmocca disabled auto-merge July 13, 2021 15:52
@carmocca carmocca enabled auto-merge (squash) July 13, 2021 15:53
@carmocca carmocca merged commit 6ce77a1 into master Jul 13, 2021
@carmocca carmocca deleted the ci/1.6-min-supported branch July 13, 2021 17:12
@carmocca carmocca mentioned this pull request Jul 22, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants