-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum PyTorch version to 1.6 #8288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8288 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 216 216
Lines 14123 14115 -8
======================================
- Hits 13095 13019 -76
- Misses 1028 1096 +68 |
Co-authored-by: Jirka Borovec <[email protected]>
Hey @ananthsub, |
As discussed today, this is primarily motivated by how long the backward-compatibility window ought to be. Users can always pin themselves to older versions of Lightning if they absolutely need older PyTorch support. Given how stable the PyTorch API has been, there's less risk of breaking changes across these versions that Lightning needs to cover for. However there are a ton of features users will get with both PyTorch and Lightning by updating to recent versions. Plus CI time/$ savings for contributors, but this is a minor concern compared to user adoption. @carmocca @Borda if you want to be more conservative, we could start with not supporting PyTorch v1.4, see how the community receives this, and then determine if this is a pattern we can continue for the next releases (e.g. always support the latest N releases of PyTorch, or PyTorch versions within last T time). |
I may say that with adding support for future PT 1.10 #8133 we can do a bit bigger step and drop also PT 1.5 for the upcoming PL 1.4 (so we would have still 5 minor PT support) |
Yes, I think it is a good approach. |
What does this PR do?
See title.
TODO: Make sure the "Current build statuses" table in the README is correct
Before submitting
PR review
Did you have fun?
Make sure you had fun coding 🙃